refactor: Create common FilterGroup component #560
+134
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panentheos
approved these changes
Nov 14, 2024
| @@ -0,0 +1,24 @@ | |||
| .filter-group { | |||
| width: 200px; | |||
| margin-bottom: 48px; | |||
There was a problem hiding this comment.
I think it's generally better to avoid external margins/padding on shared components. Depending on context, the caller might want different margins, and having it baked in can make the component harder to reuse. Instead, have the component take a className prop and apply it to the outer element, so callers can add their own margins via utility classes (mb-5 would do it in this case).
| <FilterGroup | ||
| header="Filter by message state" | ||
| onFilterSelect={(selected) => { | ||
| const stateFilter = selected.toLowerCase() as StateFilter; |
There was a problem hiding this comment.
These values are already lowercase, so this toLowerCase and the one below seem unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new reusable component for filter groups. We use them on 2 (soon to be 3) different pages and they are all implemented separately. This new component will help us maintain the styles. The UX of the filters is unchanged. The UI is also unchanged for the most part outside of some small tweak to bring certain elements in line with the designs.